Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id_vars and value_vars not accepting string scalars in melt #15765

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix id_vars and value_vars not accepting string scalars in melt #15765

merged 2 commits into from
May 16, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #15758

Also fixes an inconsistency with pandas where var_name data was always a Categorical unlike pandas

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels May 16, 2024
@mroeschke mroeschke requested a review from a team as a code owner May 16, 2024 01:54
@mroeschke mroeschke requested review from vyasr and isVoid May 16, 2024 01:54
@mroeschke mroeschke changed the title Fix id_vars and value_vars not accepting string scalars Fix id_vars and value_vars not accepting string scalars in melt May 16, 2024
@mroeschke mroeschke mentioned this pull request May 16, 2024
Closed
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fcbc1bc into rapidsai:branch-24.06 May 16, 2024
75 checks passed
@mroeschke mroeschke deleted the bug/melt/id_vars branch May 22, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] when using id_vars in .melt() , the string of the column name is broken into characters
2 participants
@mroeschke @galipremsagar