Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support filtered I/O in chunked_parquet_reader and simplify the use of parquet_reader_options #15764

Merged
merged 17 commits into from
May 21, 2024
Merged

Support filtered I/O in chunked_parquet_reader and simplify the use of parquet_reader_options #15764

merged 17 commits into from
May 21, 2024

Conversation

mhaseeb123
Copy link
Member

@mhaseeb123 mhaseeb123 commented May 15, 2024 •
edited
Loading

Description

This PR does the following:

  1. It enables the support for filtered I/O in chunked parquet reader.
  2. It simplifies the use of parquet_reader_options in parquet::readers by taking and saving the options at reader construction for later use instead of passing around options as arguments from read(), has_next() and chunked_read() to prepare_data(), read_chunk_internal() and several other internal APIs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 15, 2024
@mhaseeb123 mhaseeb123 added 2 - In Progress Currently a work in progress cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 15, 2024
galipremsagar
galipremsagar approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhaseeb123 ! This PR fixes the issue I'm facing, just verified these changes locally.

@mhaseeb123 mhaseeb123 marked this pull request as ready for review May 16, 2024 03:00
@mhaseeb123 mhaseeb123 requested a review from a team as a code owner May 16, 2024 03:00
@mhaseeb123 mhaseeb123 requested review from harrism and shrshi May 16, 2024 03:00
@karthikeyann
Copy link
Contributor

This might be a breaking change.

@mhaseeb123 mhaseeb123 added breaking Breaking change and removed non-breaking Non-breaking change labels May 16, 2024
@mhaseeb123 mhaseeb123 changed the title Support filtered I/O in chunked_parquet_reader Support filtered I/O in chunked_parquet_reader and remove duplicate options inputs to parquet::readers May 16, 2024
@mhaseeb123 mhaseeb123 changed the title Support filtered I/O in chunked_parquet_reader and remove duplicate options inputs to parquet::readers Support filtered I/O in chunked_parquet_reader and simplify the interaction between parquet_reader_options and parquet readers May 16, 2024
@mhaseeb123 mhaseeb123 changed the title Support filtered I/O in chunked_parquet_reader and simplify the interaction between parquet_reader_options and parquet readers Support filtered I/O in chunked_parquet_reader and simplify the use of parquet_reader_options May 17, 2024
@vuule vuule requested review from ttnghia and vuule May 17, 2024 16:33
@mhaseeb123 mhaseeb123 marked this pull request as draft May 17, 2024 19:50
@mhaseeb123 mhaseeb123 marked this pull request as ready for review May 17, 2024 21:30
@mhaseeb123 mhaseeb123 added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 17, 2024
@mhaseeb123 mhaseeb123 mentioned this pull request May 17, 2024
Open
@mhaseeb123 mhaseeb123 requested a review from karthikeyann May 17, 2024 22:48
karthikeyann
karthikeyann approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mhaseeb123 mhaseeb123 self-assigned this May 20, 2024
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 20, 2024
@galipremsagar
Copy link
Contributor

/okay to test

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit eb7b50a into rapidsai:branch-24.06 May 21, 2024
73 of 75 checks passed
@mhaseeb123 mhaseeb123 deleted the pq-chunked-reader-filtered-io branch May 21, 2024 01:33
@mhaseeb123 mhaseeb123 mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@mhaseeb123 mhaseeb123

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhaseeb123 @karthikeyann @galipremsagar @ttnghia @vuule