-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change thrust::count_if call to raw kernel in strings split APIs #15762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What is the benefit of rolling your own kernel vs using count_if? In what way is it better? |
Yes, good question. In this case, the |
/merge |
Description
Fixes calls to
thrust::count_if
in strings split APIs to better handle large strings.Checklist