Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DatetimeIndex.loc for all types of ordering cases #15761

Merged
merged 3 commits into from
May 16, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #15742

This PR resolves issues with returning incorrect ranges for DatetimeIndex.loc when the index objects are monotonically decreasing. Additionally, I went ahead and fixed it for all cases, (i.e., random ordering) too.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels May 15, 2024
@galipremsagar galipremsagar requested a review from mroeschke May 15, 2024 19:03
@galipremsagar galipremsagar self-assigned this May 15, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner May 15, 2024 19:03
@galipremsagar galipremsagar requested a review from bdice May 15, 2024 19:03
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 15, 2024
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 15, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bdd48f1 into rapidsai:branch-24.06 May 16, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] loc returning incorrect results for DatetimeIndex that is in monotonically decreasing
2 participants