Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate circular reference in DataFrame/Series.iloc/loc #15749

Merged
merged 2 commits into from
May 15, 2024
Merged

Eliminate circular reference in DataFrame/Series.iloc/loc #15749

merged 2 commits into from
May 15, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #15748

The performance implication can be seen in the issue

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels May 14, 2024
@mroeschke mroeschke requested a review from a team as a code owner May 14, 2024 21:02
@mroeschke mroeschke requested review from wence- and isVoid May 14, 2024 21:02
wence-
wence- approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b5f6aa5 into rapidsai:branch-24.06 May 15, 2024
70 checks passed
@mroeschke mroeschke deleted the bug/circular_ref/indexing branch May 15, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- wence- approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] iloc/loc keeps circular reference to original DataFrame/Series
3 participants
@mroeschke @wence- @galipremsagar