Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary 'setuptools' host dependency, simplify dependencies.yaml #15736

Merged
merged 3 commits into from
May 15, 2024
Merged

remove unnecessary 'setuptools' host dependency, simplify dependencies.yaml #15736

merged 3 commits into from
May 15, 2024

Conversation

jameslamb
Copy link
Member

Description

Pulls out some changes I noticed while working on #15245.

  • removes host dependency on setuptools for cudf and cudf_kafka
    • they don't need it now that they build with scikit-build-core
  • consolidates some redundant blocks in dependencies.yaml

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 13, 2024
@github-actions github-actions bot added the conda label May 13, 2024
@jameslamb jameslamb changed the title WIP: remove unnecessary 'setuptools' host dependency, simplify dependencies.ayml remove unnecessary 'setuptools' host dependency, simplify dependencies.ayml May 13, 2024
@jameslamb jameslamb removed the 2 - In Progress Currently a work in progress label May 13, 2024
@jameslamb jameslamb marked this pull request as ready for review May 13, 2024 22:23
@jameslamb jameslamb requested a review from a team as a code owner May 13, 2024 22:23
@jameslamb jameslamb requested a review from AyodeAwe May 13, 2024 22:23
@jameslamb jameslamb requested a review from bdice May 14, 2024 14:15
@jameslamb jameslamb changed the title remove unnecessary 'setuptools' host dependency, simplify dependencies.ayml remove unnecessary 'setuptools' host dependency, simplify dependencies.yaml May 14, 2024
@AyodeAwe
Copy link
Contributor

AyodeAwe commented May 15, 2024 •
edited
Loading

@jameslamb PR looks good to me but do we want to merge in latest changes?

@jameslamb
Copy link
Member Author

thanks @AyodeAwe ! Yep I just merged in the latest branch-24.06.

@vyasr
Copy link
Contributor

vyasr commented May 15, 2024

/merge

@rapids-bot rapids-bot bot merged commit 516d0f9 into rapidsai:branch-24.06 May 15, 2024
70 checks passed
@jameslamb jameslamb deleted the dependencies-refactor branch May 15, 2024 22:52
This was referenced May 21, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

@bdice bdice Awaiting requested review from bdice

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @AyodeAwe @vyasr