Add JNI bindings for zstd compression of NVCOMP. #15729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <[email protected]>
firestarman
added
feature request
Signed-off-by: Firestarman <[email protected]>
|
/ok to test |
Signed-off-by: Firestarman <[email protected]>
|
/ok to test |
jlowe
approved these changes
May 13, 2024
|
|
||
| public class NvcompTest { | ||
| private static final HostMemoryAllocator hostMemoryAllocator = DefaultHostMemoryAllocator.get(); | ||
|
|
||
| private static final Logger log = LoggerFactory.getLogger(ColumnVector.class); | ||
|
|
||
| private final long chunkSize = 64 * 1024; | ||
| private final long targetIntermediteSize = Long.MAX_VALUE; |
There was a problem hiding this comment.
Suggested change
| private final long targetIntermediteSize = Long.MAX_VALUE; | |
| private final long targetIntermediateSize = Long.MAX_VALUE; |
There was a problem hiding this comment.
Nice catch. But I'll merge this first, and correct typo in the future PRs.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LZ4 is already supported, and this PR mainly adds JNI bindings for the ZSTD compression of NVCOMP.
It extracts the common code from LZ4 compressor and decompressor and put it into two new classes
BatchedCompressorandBatchedDecompressor. By extending from these two classes, it adds in the ZSTD support.Description
Checklist