Fix multibyte check for case convert for large strings #15721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
davidwendt
added
3 - Ready for Review
| total_bytes, | ||
| d_new_chars); | ||
| constexpr size_t block_size{256}; | ||
| // cudf::detail::grid_1d limited to size_type elements |
There was a problem hiding this comment.
should we fix this? to use size_t ?
There was a problem hiding this comment.
Perhaps worth a discussion. I'm not sure how common this will be and how much impact it will have.
Certainly not something I'd wish to solve in this PR.
ttnghia
reviewed
May 14, 2024
ttnghia
reviewed
May 14, 2024
ttnghia
approved these changes
May 15, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes check for multibyte characters on large strings column. The
thrust::count_ifexceeds the int64 reduce type maximum and so the logic was recoded as a native kernel. Added additional tests and fixed subsequent errors where kernels are launched with greater than max(size_type) threads.Checklist