Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return same type as the original index for .loc operations #15717

Merged
merged 5 commits into from
May 12, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #15716

This PR makes changes to .loc by preserving the original type at the end of the operation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels May 10, 2024
@galipremsagar galipremsagar requested a review from mroeschke May 10, 2024 15:52
@galipremsagar galipremsagar self-assigned this May 10, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner May 10, 2024 15:52
@galipremsagar galipremsagar requested a review from vyasr May 10, 2024 15:52
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 10, 2024
@galipremsagar galipremsagar requested a review from mroeschke May 10, 2024 20:36
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 10, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 425a5da into rapidsai:branch-24.06 May 12, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] df.loc needs to return index of same types
2 participants