Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct static builds + static arrow #15715

Merged
merged 3 commits into from
May 13, 2024
Merged

Correct static builds + static arrow #15715

merged 3 commits into from
May 13, 2024

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented May 10, 2024 •
edited
Loading

Description

Correct the CMake logic in arrow so that we can properly build cudf + arrow statically

Fixes #15714

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Non-breaking change labels May 10, 2024
@github-actions github-actions bot added the ci label May 10, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels May 10, 2024
ttnghia
ttnghia approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that this fixes the issue #15714.

@ttnghia ttnghia linked an issue May 10, 2024 that may be closed by this pull request
[BUG] cmake fails to configure static libcudf due to arrow issues #15714
Closed
@robertmaynard robertmaynard marked this pull request as ready for review May 10, 2024 17:46
@robertmaynard robertmaynard requested review from a team as code owners May 10, 2024 17:46
@robertmaynard robertmaynard requested a review from raydouglass May 10, 2024 17:46
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 915c6be into rapidsai:branch-24.06 May 13, 2024
70 checks passed
@robertmaynard robertmaynard deleted the bug/correct_arrow_16_static_build_issues branch May 13, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@ttnghia ttnghia ttnghia approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cmake fails to configure static libcudf due to arrow issues
4 participants
@robertmaynard @ttnghia @AyodeAwe @KyleFromNVIDIA