Raise errors for unsupported operations on certain types #15712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 20, 2024
| @@ -167,6 +167,46 @@ cdef class GroupBy: | |||
| included_aggregations_i = [] | |||
| col_aggregations = [] | |||
| for agg in aggs: | |||
| str_agg = str(agg) | |||
There was a problem hiding this comment.
Question: Is it not enough to raise the TypeError if the if valid_aggregations == "ALL" or agg_obj.kind in valid_aggregations: condition below fails?
There was a problem hiding this comment.
Ideally yes, but that is a very loose condition for many operations vs dtype matrix we have and libcudf seems to be silently returning empty columns for those. We need to dig deeper for other types aswell.
There was a problem hiding this comment.
OK. I suppose this PR is a good enough intermediate solution until we can centeralize this in get_valid_aggregation or similar.
mroeschke
approved these changes
May 20, 2024
|
/merge |
galipremsagar
added
the
5 - Ready to Merge
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 22, 2024
After we made our groupby fail more aggressively for unsupported types in #15712, `Groupby.collect` started to fail on string column, where this isn't a supported aggregation on string column in pandas and this method doesn't exist in pandas Groupby, hence this PR suggest the alternative equivalent and deprecates the API to be removed in next release. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Matthew Roeschke (https://github.com/mroeschke) - Richard (Rick) Zamora (https://github.com/rjzamora) URL: #15808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #15668
This PR raises errors for groupby operations on un-supported types.
Checklist