Fix split-record result list column offset type #15707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes offsets type for list column returned by
cudf::strings::split_record
andcudf::strings::split_record_re
when large-strings enabled. The list column offsets type must be INT32. The code was changed to use the appropriatemake_offsets_child_column
utility function.Also added some
is_large_strings_enabled()
checks to check-overflow gtests.This allows all current gtests to pass when the large-strings support environment variable is set.
Checklist