Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split-record result list column offset type #15707

Merged
merged 1 commit into from
May 16, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes offsets type for list column returned by cudf::strings::split_record and cudf::strings::split_record_re when large-strings enabled. The list column offsets type must be INT32. The code was changed to use the appropriate make_offsets_child_column utility function.
Also added some is_large_strings_enabled() checks to check-overflow gtests.
This allows all current gtests to pass when the large-strings support environment variable is set.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2024
@davidwendt davidwendt self-assigned this May 9, 2024
@davidwendt davidwendt requested a review from a team as a code owner May 9, 2024 17:02
@davidwendt davidwendt requested review from mythrocks and nvdbaranec May 9, 2024 17:02
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bf255cb into rapidsai:branch-24.06 May 16, 2024
70 checks passed
@davidwendt davidwendt deleted the ls-fix-tests branch May 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants