Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade arrow to 16 #15703

Merged
merged 10 commits into from
May 9, 2024
Merged

Upgrade arrow to 16 #15703

merged 10 commits into from
May 9, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented May 9, 2024

Description

This PR upgrades arrow to 16. This PR also contains fixes to pytests because of breaking API changes in pyarrow.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2024
@galipremsagar galipremsagar self-assigned this May 9, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda labels May 9, 2024
@galipremsagar galipremsagar changed the title Upgrade arrow to 16 Upgrade arrow to 16 May 9, 2024
@galipremsagar galipremsagar marked this pull request as ready for review May 9, 2024 03:27
@galipremsagar galipremsagar requested review from a team as code owners May 9, 2024 03:27
@galipremsagar galipremsagar requested review from bdice and mroeschke May 9, 2024 03:27
@galipremsagar galipremsagar mentioned this pull request May 9, 2024
3 tasks
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question/comment. Otherwise LGTM - Thanks!

pa_table = df.to_arrow(preserve_index=index)
return pq.write_to_dataset(
pa_table,
root_path=path,
partition_filename_cb=partition_file_name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to warn or raise if the user specifies partition_file_name and the engine is not "cudf"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might get very noisy because we have many such parameters, I documented the change.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 9, 2024
@galipremsagar
Copy link
Contributor Author

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants