-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade arrow
to 16
#15703
Upgrade arrow
to 16
#15703
Conversation
Co-authored-by: Bradley Dice <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question/comment. Otherwise LGTM - Thanks!
pa_table = df.to_arrow(preserve_index=index) | ||
return pq.write_to_dataset( | ||
pa_table, | ||
root_path=path, | ||
partition_filename_cb=partition_file_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to warn or raise if the user specifies partition_file_name
and the engine is not "cudf"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might get very noisy because we have many such parameters, I documented the change.
/merge |
Description
This PR upgrades
arrow
to16
. This PR also contains fixes to pytests because of breaking API changes in pyarrow.Checklist