Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI s3 api command to fetch latest results #15687

Merged
merged 7 commits into from
May 7, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented May 7, 2024

Description

An s3 fetch api seems to be returning incorrectly ordered output, this PR fixes the issue.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels May 7, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner May 7, 2024 14:04
@galipremsagar galipremsagar marked this pull request as draft May 7, 2024 14:05
@github-actions github-actions bot added the ci label May 7, 2024
@galipremsagar galipremsagar changed the title test Fix CI s3 api command to fetch latest results May 7, 2024
@galipremsagar galipremsagar self-assigned this May 7, 2024
@galipremsagar galipremsagar added this to the cudf.pandas API coverage milestone May 7, 2024
@galipremsagar galipremsagar marked this pull request as ready for review May 7, 2024 14:26
read -r COMPARE_ENV < s3_output.txt
export COMPARE_ENV
aws s3api list-objects-v2 --bucket rapids-downloads --prefix "nightly/" --query "sort_by(Contents[?ends_with(Key, '_py${PY_VER}.main-${RAPIDS_FULL_VERSION}-results.json')], &LastModified)[::].[Key]" --output text > s3_output.txt
cat s3_output.txt
Copy link
Contributor Author

@galipremsagar galipremsagar May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this cat for debug purposes to see what all files are being fetched.

Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion, but looks good.

ci/cudf_pandas_scripts/pandas-tests/diff.sh Outdated Show resolved Hide resolved
Co-authored-by: Ray Douglass <[email protected]>
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2e81857 into rapidsai:branch-24.06 May 7, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants