Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pre commit hooks #15685

Merged
merged 3 commits into from
May 7, 2024
Merged

Upgrade pre commit hooks #15685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cbb335
Upgrade mypy
wence- Apr 10, 2024
ea66192
Update all pre-commit hooks
wence- May 7, 2024
53994e7
Fix type annotation
wence- May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
rev: v4.6.0
hooks:
- id: trailing-whitespace
exclude: |
Expand All @@ -24,11 +24,11 @@ repos:
files: python/.*
types_or: [python, cython, pyi]
- repo: https://github.com/MarcoGorelli/cython-lint
rev: v0.16.0
rev: v0.16.2
hooks:
- id: cython-lint
- repo: https://github.com/pre-commit/mirrors-mypy
rev: 'v1.3.0'
rev: 'v1.10.0'
hooks:
- id: mypy
additional_dependencies: [types-cachetools]
Expand All @@ -39,7 +39,7 @@ repos:
"python/dask_cudf/dask_cudf"]
pass_filenames: false
- repo: https://github.com/nbQA-dev/nbQA
rev: 1.7.1
rev: 1.8.5
hooks:
- id: nbqa-isort
# Use the cudf_kafka isort orderings in notebooks so that dask
Expand All @@ -52,7 +52,7 @@ repos:
types_or: [c, c++, cuda]
args: ["-fallback-style=none", "-style=file", "-i"]
- repo: https://github.com/sirosen/texthooks
rev: 0.6.3
rev: 0.6.6
hooks:
- id: fix-smartquotes
exclude: |
Expand Down Expand Up @@ -124,12 +124,12 @@ repos:
^CHANGELOG.md$
)
- repo: https://github.com/rapidsai/dependency-file-generator
rev: v1.8.0
rev: v1.13.4
hooks:
- id: rapids-dependency-file-generator
args: ["--clean"]
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.3.4
rev: v0.4.3
hooks:
- id: ruff
files: python/.*$
Expand Down
2 changes: 1 addition & 1 deletion python/cudf/cudf/core/column/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2211,7 +2211,7 @@ def _mask_from_cuda_array_interface_desc(obj, cai_mask) -> Buffer:
raise NotImplementedError(f"Cannot infer mask from typestr {typestr}")


def serialize_columns(columns) -> Tuple[List[dict], List]:
def serialize_columns(columns: list[ColumnBase]) -> Tuple[List[dict], List]:
"""
Return the headers and frames resulting
from serializing a list of Column
Expand Down
5 changes: 2 additions & 3 deletions python/cudf/cudf/pandas/fast_slow_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ def _replace_closurevars(
f: types.FunctionType,
attribute_name: Literal["_fsproxy_slow", "_fsproxy_fast"],
seen: Set[int],
) -> types.FunctionType:
) -> Callable[..., Any]:
"""
Return a copy of `f` with its closure variables replaced with
their corresponding slow (or fast) types.
Expand Down Expand Up @@ -1133,12 +1133,11 @@ def _replace_closurevars(
argdefs=f.__defaults__,
closure=g_closure,
)
g = functools.update_wrapper(
return functools.update_wrapper(
g,
f,
assigned=functools.WRAPPER_ASSIGNMENTS + ("__kwdefaults__",),
)
return g


_SPECIAL_METHODS: Set[str] = {
Expand Down
Loading