Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement binaryops for proxy types #15684

Merged
merged 8 commits into from
May 8, 2024
Merged

Properly implement binaryops for proxy types #15684

merged 8 commits into from
May 8, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes #15675
This PR makes changes to cudf.pandas machinery by not calling operator.op functions insider the re-direct calls.

Forked from #14534

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels May 7, 2024
@galipremsagar galipremsagar added this to the Proxying - cudf.pandas milestone May 7, 2024
@galipremsagar galipremsagar requested a review from wence- May 7, 2024 11:57
@galipremsagar galipremsagar self-assigned this May 7, 2024
@galipremsagar galipremsagar changed the title Properly implement binaryops Properly implement binaryops for proxy types May 7, 2024
@galipremsagar galipremsagar marked this pull request as ready for review May 7, 2024 11:57
@galipremsagar galipremsagar requested a review from a team as a code owner May 7, 2024 11:57
@galipremsagar galipremsagar requested a review from vyasr May 7, 2024 11:57
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 7, 2024
@galipremsagar galipremsagar mentioned this pull request May 7, 2024
Merged
@galipremsagar galipremsagar requested a review from mroeschke May 7, 2024 12:01
@galipremsagar
Copy link
Contributor Author

@bdice I'd like to get this PR merged before #15695 and then update the list there.

@galipremsagar galipremsagar requested a review from bdice May 8, 2024 14:47
@galipremsagar galipremsagar requested a review from bdice May 8, 2024 16:20
bdice
bdice approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much cleaner! That's good. :)

@galipremsagar
Copy link
Contributor Author

Thanks @bdice !

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 8, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit eaf5556 into rapidsai:branch-24.06 May 8, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence-

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
Proxying - cudf.pandas
Development

Successfully merging this pull request may close these issues.

[BUG] Binary operators dunder methods should not call operator.op in cudf.pandas
2 participants
@galipremsagar @bdice