Misc Column cleanups #15682
Merged
Misc Column cleanups #15682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
| @@ -820,7 +818,7 @@ def take( | |||
|
|
|||
| # TODO: For performance, the check and conversion of gather map should | |||
| # be done by the caller. This check will be removed in future release. | |||
| if not is_integer_dtype(indices.dtype): | |||
| if indices.dtype.kind not in {"u", "i"}: | |||
There was a problem hiding this comment.
Wouldn't this be a problem incase of StructColumn and DecimalColumn's? Those types will lack .kind attribute.
There was a problem hiding this comment.
They have a default of "O" (object type), so that would work here since we want to exclude those
In [1]: import cudf
In [2]: cudf.Decimal128Dtype(2)
Out[2]: Decimal128Dtype(precision=2, scale=0)
In [3]: cudf.Decimal128Dtype(2).kind
Out[3]: 'O'
In [4]: cudf.StructDtype({"a": "int64"}).kind
Out[4]: 'O'There was a problem hiding this comment.
Okay, as long as that's covered we are good.
galipremsagar
approved these changes
May 8, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist