Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce runtime for ParquetChunkedReaderInputLimitTest gtests #15672

Merged
merged 1 commit into from
May 16, 2024
Merged

Reduce runtime for ParquetChunkedReaderInputLimitTest gtests #15672

merged 1 commit into from
May 16, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Reduces the runtime for the ParquetChunkedReaderInputLimitTest.List and ParquetChunkedReaderInputLimitTest.Mixed which together are 1/3 the total time for PARQUET_TEST.
These two tests produce multi-GB test files that are not strictly necessary for testing the chunked reader since the chunk sizes are controllable. The changes here reduce the runtime for these 2 tests by about 1/3 the original runtime.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 6, 2024
@davidwendt davidwendt self-assigned this May 6, 2024
@davidwendt davidwendt mentioned this pull request May 7, 2024
Closed
@davidwendt
Copy link
Contributor Author

Depends on #15735

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 14, 2024
@davidwendt davidwendt marked this pull request as ready for review May 14, 2024 16:02
@davidwendt davidwendt requested a review from a team as a code owner May 14, 2024 16:02
vuule
vuule approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as @nvdbaranec is fine with the changes :)

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1e92f3f into rapidsai:branch-24.06 May 16, 2024
70 checks passed
@davidwendt davidwendt deleted the test-pq-chunk-reader branch May 16, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmattione-nvidia pmattione-nvidia pmattione-nvidia approved these changes

@vuule vuule vuule approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vuule @pmattione-nvidia