Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add large-strings gtest for cudf::interleave_columns #15669

Merged
merged 2 commits into from
May 9, 2024
Merged

Add large-strings gtest for cudf::interleave_columns #15669

merged 2 commits into from
May 9, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Adds a gtest for cudf::interleave_columns that tests it can produce large-strings appropriately.
Follow on to #15544

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 6, 2024
@davidwendt davidwendt self-assigned this May 6, 2024
@github-actions github-actions bot added the CMake CMake build issue label May 6, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 7, 2024
@davidwendt davidwendt marked this pull request as ready for review May 7, 2024 21:54
@davidwendt davidwendt requested a review from a team as a code owner May 7, 2024 21:54
@davidwendt davidwendt requested review from mythrocks and nvdbaranec May 7, 2024 21:54
mythrocks
mythrocks approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
+1, barring a couple of consts that could be added.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 65a51ff into rapidsai:branch-24.06 May 9, 2024
70 checks passed
@davidwendt davidwendt deleted the interleave-ls-gtest branch May 9, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@mythrocks mythrocks mythrocks approved these changes

@vyasr vyasr vyasr approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @vyasr @mythrocks @PointKernel