Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use experimental make_strings_children for multi-replace_re #15667

Merged
merged 1 commit into from
May 8, 2024
Merged

Use experimental make_strings_children for multi-replace_re #15667

merged 1 commit into from
May 8, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates multi-pattern version of cudf::strings::replace_re to use the new experimental make_strings_children which supports building large strings.

Reference #15579

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 6, 2024
@davidwendt davidwendt self-assigned this May 6, 2024
@davidwendt davidwendt marked this pull request as ready for review May 6, 2024 19:07
@davidwendt davidwendt requested a review from a team as a code owner May 6, 2024 19:07
@davidwendt davidwendt requested review from mythrocks and nvdbaranec May 6, 2024 19:07
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2056d0f into rapidsai:branch-24.06 May 8, 2024
70 checks passed
@davidwendt davidwendt deleted the msc-multi-re branch May 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@mythrocks mythrocks mythrocks approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @mythrocks @karthikeyann