Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Index contains for error validations and float vs int comparisons #15657

Merged
merged 3 commits into from
May 6, 2024
Merged

Fix Index contains for error validations and float vs int comparisons #15657

merged 3 commits into from
May 6, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented May 5, 2024 •
edited
Loading

Description

Fixes: #15656

This PR:

  • Raises error for non-hashable values passed to __contains__
  • Fixes comparison of float values with int columns

Forks out of #14534

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas labels May 5, 2024
@galipremsagar galipremsagar self-assigned this May 5, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner May 5, 2024 19:00
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 5, 2024
@galipremsagar galipremsagar requested a review from mroeschke May 6, 2024 20:49
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 6, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d5ad366 into rapidsai:branch-24.06 May 6, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] __contains__ not comparing int vs float values
2 participants
@galipremsagar @mroeschke