Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve sub-second data for time scalars in column construction #15655

Merged
merged 5 commits into from
May 7, 2024
Merged

Preserve sub-second data for time scalars in column construction #15655

merged 5 commits into from
May 7, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #15654

This PR makes fixes such that sub-second timestamp data is not being dropped in column construction.

Forks out of #14534

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels May 5, 2024
@galipremsagar galipremsagar added this to the cudf.pandas API coverage milestone May 5, 2024
@galipremsagar galipremsagar self-assigned this May 5, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner May 5, 2024 08:45
@galipremsagar galipremsagar requested review from vyasr and mroeschke May 5, 2024 08:45
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 5, 2024
@galipremsagar galipremsagar added the cudf.pandas Issues specific to cudf.pandas label May 6, 2024
@galipremsagar galipremsagar requested a review from mroeschke May 6, 2024 19:16
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 6, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5d244df into rapidsai:branch-24.06 May 7, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
cudf.pandas API coverage
Development

Successfully merging this pull request may close these issues.

[BUG] Timestamp scalars losing sub-second data
2 participants
@galipremsagar @mroeschke