Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large strings support in MD5 and SHA hashers #15631

Merged
merged 1 commit into from
May 3, 2024
Merged

Large strings support in MD5 and SHA hashers #15631

merged 1 commit into from
May 3, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates the hash functions for md5 and sha to support creating large strings results.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 1, 2024
@davidwendt davidwendt self-assigned this May 1, 2024
@davidwendt davidwendt requested a review from a team as a code owner May 1, 2024 18:03
@davidwendt davidwendt requested review from robertmaynard and vuule May 1, 2024 18:03
bdice
bdice approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 18f2e7a into rapidsai:branch-24.06 May 3, 2024
75 checks passed
@davidwendt davidwendt deleted the mocc-hashers branch May 3, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @vuule