Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ColumnBase.__cuda_array_interface__ opt out instead of opt in #15622

Merged
merged 5 commits into from
May 1, 2024
Merged

Make ColumnBase.__cuda_array_interface__ opt out instead of opt in #15622

merged 5 commits into from
May 1, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Column types that support CAI already have custom NotImplementedErrors, and since the implementation is the same for datetime and numeric columns, moving their implementation to ColumnBase

Should help address timedelta support in #15615 cc @brandon-b-miller

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 30, 2024
@mroeschke mroeschke requested a review from a team as a code owner April 30, 2024 18:22
galipremsagar
galipremsagar requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it could you move __cuda_array_interface__ implementation from Decimal64Column to DecimalBaseColumn? So that all decimal column types are covered.

@mroeschke
Copy link
Contributor Author

While we are at it could you move __cuda_array_interface__ implementation from Decimal64Column to DecimalBaseColumn? So that all decimal column types are covered.

Nice catch! Moved in the last commit

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 2eeacb9 into rapidsai:branch-24.06 May 1, 2024
70 checks passed
@galipremsagar
Copy link
Contributor

Thank you @mroeschke for handling this!

@mroeschke mroeschke deleted the ref/cai/column branch May 1, 2024 01:02
@mroeschke mroeschke mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar