Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large strings support for cudf::gather #15621

Merged
merged 1 commit into from
May 1, 2024
Merged

Large strings support for cudf::gather #15621

merged 1 commit into from
May 1, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Apr 30, 2024 •
edited by bdice
Loading

Description

Replaces make_offsets_child_column with strings specific version in cudf::strings::detail::gather function.
Fixes issue found here: #13733 (comment)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 30, 2024
@davidwendt davidwendt self-assigned this Apr 30, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 30, 2024
@davidwendt davidwendt marked this pull request as ready for review April 30, 2024 20:18
@davidwendt davidwendt requested a review from a team as a code owner April 30, 2024 20:18
bdice
bdice approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite funny how small this PR can be, while enabling such a significant advance. Thanks!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f5c7778 into rapidsai:branch-24.06 May 1, 2024
70 checks passed
@davidwendt davidwendt deleted the ls-gather branch May 1, 2024 14:03
@davidwendt davidwendt mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

@harrism harrism harrism approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @harrism @bdice @PointKernel