Backport: Relax protobuf lower bound to 3.20. (#15506) #15610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR drops the lower bound of protobuf to 3.20, to make cuDF compatible with the versions used in Google Colab. I tested this manually in Google Colab, which uses protobuf 3.20, and cuDF 24.02 seemed to work fine when reading ORC statistics (the only runtime feature in cuDF that needs protobuf). Note: cuDF 24.02 was built was a newer protobuf/protoc, version 4.x. I will test this by forcing protobuf 3.20 in CI, and then revert those changes if tests pass. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Nick Becker (https://github.com/beckernick) - Ray Douglass (https://github.com/raydouglass) - Matthew Roeschke (https://github.com/mroeschke) URL: rapidsai#15506
bdice
added
improvement
bdice
requested review from
wence- and
galipremsagar
and removed request for
a team
galipremsagar
approved these changes
Apr 29, 2024
raydouglass
approved these changes
Apr 29, 2024
cupy 13.1 added a warning about the jitify cache warming up that we must silence in our test suite for it to pass. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - https://github.com/brandon-b-miller - GALI PREM SAGAR (https://github.com/galipremsagar) - Bradley Dice (https://github.com/bdice) URL: rapidsai#15574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #15506 to cuDF 24.04.
Also backports #15574 to ignore a warning from newer cupy releases.