Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use experimental make_strings_children for json/csv writers #15599

Merged
merged 1 commit into from
May 1, 2024
Merged

Use experimental make_strings_children for json/csv writers #15599

merged 1 commit into from
May 1, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates the JSON and CSV writer functions to use the new experimental make_strings_children.
Also included is an update to the JSON_BENCH benchmark for get_json_object.

Reference #15579

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 25, 2024
@davidwendt davidwendt self-assigned this Apr 25, 2024
@davidwendt davidwendt requested a review from a team as a code owner April 25, 2024 17:03
@davidwendt davidwendt mentioned this pull request Apr 25, 2024
Closed
33 tasks
karthikeyann
karthikeyann approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The writers use string APIs. Those need to be converted to use experimental api as well.

@davidwendt
Copy link
Contributor Author

The writers use string APIs. Those need to be converted to use experimental api as well.

Yes, all occurrences of make_strings_children are to be replaced in other PRs.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4aabf51 into rapidsai:branch-24.06 May 1, 2024
71 checks passed
@davidwendt davidwendt deleted the ls-json branch May 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @karthikeyann