Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use experimental make_strings_children for strings replace/filter/translate #15586

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Use experimental make_strings_children for strings replace/filter/translate #15586

merged 1 commit into from
Apr 30, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates strings replace functions to use the new experimental make_strings_children which supports building large strings.

Reference #15579

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 23, 2024
@davidwendt davidwendt self-assigned this Apr 23, 2024
@davidwendt davidwendt mentioned this pull request Apr 23, 2024
Closed
33 tasks
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 24, 2024
@davidwendt davidwendt marked this pull request as ready for review April 24, 2024 13:19
@davidwendt davidwendt requested a review from a team as a code owner April 24, 2024 13:19
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1fd3db8 into rapidsai:branch-24.06 Apr 30, 2024
70 checks passed
@davidwendt davidwendt deleted the ls-replace branch April 30, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @karthikeyann @ttnghia