Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't materialize column during RangeIndex methods #15582

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Additionally implements some methods that are defined on BaseIndex that were not implemented on RangeIndex and adds some typing

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 23, 2024
@mroeschke mroeschke requested a review from a team as a code owner April 23, 2024 00:36
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

def values_host(self):
return self.to_pandas().values
def values_host(self) -> np.ndarray:
return np.arange(start=self.start, stop=self.stop, step=self.step)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👌

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 70a5b2b into rapidsai:branch-24.06 Apr 24, 2024
70 checks passed
@mroeschke mroeschke deleted the ref/ri/methods branch April 24, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants