Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large strings support for cudf::fill #15555

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Large strings support for cudf::fill #15555

merged 2 commits into from
Apr 23, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Apr 17, 2024 •
edited
Loading

Description

Updates the cudf::fill strings specialization logic to use gather-based make_strings_column instead of the make_strings_children since the gather-based function already efficiently supports longs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 17, 2024
@davidwendt davidwendt self-assigned this Apr 17, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 22, 2024
@davidwendt davidwendt marked this pull request as ready for review April 22, 2024 18:19
@davidwendt davidwendt requested a review from a team as a code owner April 22, 2024 18:19
mhaseeb123
mhaseeb123 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Looks good to me!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 73306f1 into rapidsai:branch-24.06 Apr 23, 2024
79 checks passed
@davidwendt davidwendt deleted the ls-fill branch April 23, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@harrism harrism harrism approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @harrism @mhaseeb123