Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy JSON reader from Python #15538

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Remove legacy JSON reader from Python #15538

merged 3 commits into from
Apr 16, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 15, 2024 •
edited
Loading

Description

This PR removes the engine="cudf_legacy" option from Python.

This is a part of #15537.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner April 15, 2024 22:13
@bdice bdice requested review from wence- and isVoid April 15, 2024 22:13
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 15, 2024
@bdice bdice mentioned this pull request Apr 15, 2024
Closed
7 tasks
@bdice bdice added improvement Improvement / enhancement to an existing function breaking Breaking change labels Apr 15, 2024
@bdice bdice self-assigned this Apr 15, 2024
@bdice
Copy link
Contributor Author

bdice commented Apr 15, 2024

Depends on #15539 to fix CI.

@bdice
Copy link
Contributor Author

bdice commented Apr 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit 77abf03 into rapidsai:branch-24.06 Apr 16, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @galipremsagar