Preserve column metadata during more DataFrame operations #15519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
3 tasks
vyasr
reviewed
Apr 17, 2024
|
|
||
| return self._mimic_inplace( | ||
| self._from_data_like_self(out), inplace=inplace | ||
| self._from_data_like_self(self._data._from_columns_like_self(out)), |
There was a problem hiding this comment.
I still see a number of instances of _from_data_like_self. Can we use _from_data instead consistently now?
There was a problem hiding this comment.
Can we use _from_data instead consistently now?
Getting there but not quite yet due to preserving the index. IndexedFrame._from_data_like_self is like _from_data but preserves the existing index which IndexedFrame._from_data doesn't do by default.
wence-
approved these changes
May 2, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #15410, adds a
ColumnAccessor._from_columns_like_selfthat will preserve column attributes during DataFrame operations. This can wholly replace_from_data_like_selfChecklist