nanoarrow uses package override for proper pinned versions generation #15515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
jlowe
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Thanks, @robertmaynard! Verified this fixes #15512 after building spark-rapids-jni with libcudf.dependency.mode=latest to update the pinned dependency descriptor files and then building with libcudf.dependency.mode=pinned.
vyasr
approved these changes
Apr 11, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The usage of
PATCH_COMMANDwithrapids_cpm_findisn't capturable by+rapids_cpm_generate_pinned_versions. So we use a nanoarrow json override file to hold the patch we need applied and the custom SHA1 to check out.Checklist