Migrate string capitalize APIs to pylibcudf
#15503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
feature request
vyasr
requested changes
May 23, 2024
3 tasks
brandon-b-miller
requested review from
msarahan,
harrism and
shrshi
and removed request for
msarahan,
harrism and
shrshi
KyleFromNVIDIA
approved these changes
May 28, 2024
vyasr
approved these changes
May 28, 2024
| @@ -15,6 +15,7 @@ | |||
| set(cython_sources aggregation.pyx binaryop.pyx copying.pyx replace.pyx reduce.pxd | |||
| stream_compaction.pyx types.pyx unary.pyx | |||
| ) | |||
| add_subdirectory(strings) | |||
There was a problem hiding this comment.
For consistency with other files I'd suggest putting this after the rapids_cython_create_modules call, but it doesn't really matter.
There was a problem hiding this comment.
I'm fine leaving this as-is, but if the entire module is just the enum I sort of wonder if we shouldn't just lift it up directly into the __init__.py/pxd files.
There was a problem hiding this comment.
For me the main justification for leaving it is that if I'd usually #include a libcudf header to make use of some API or object, I think I should expect to import or cimport it from the corresponding pylibcudf "namespace".
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the
pylibcudf.strings.capitalizenamespace and migrates the cuDF cython to use it. Depends on #15489Part of #15162