Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new patch to hide more CCCL APIs #15493

Merged
merged 4 commits into from
May 8, 2024
Merged

Add new patch to hide more CCCL APIs #15493

merged 4 commits into from
May 8, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 9, 2024 •
edited
Loading

Description

See rapidsai/rapids-cmake#580

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Apr 9, 2024
@vyasr vyasr self-assigned this Apr 9, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Apr 9, 2024
@vyasr vyasr marked this pull request as ready for review April 10, 2024 17:56
@vyasr vyasr requested a review from a team as a code owner April 10, 2024 17:56
@vyasr vyasr requested a review from robertmaynard April 10, 2024 17:56
robertmaynard
robertmaynard requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpp/cmake/thirdparty/patches/kernel_pointer_hiding.diff isn't required anymore since we have merged that patch into rapids-cmake proper

@bdice
Copy link
Contributor

bdice commented Apr 10, 2024

cpp/cmake/thirdparty/patches/kernel_pointer_hiding.diff isn't required anymore since we have merged that patch into rapids-cmake proper

Good catch. Something felt off about this PR and I couldn't put my finger on it. Just delete that file and it'll be used from rapids-cmake's copy.

@vyasr
Copy link
Contributor Author

vyasr commented Apr 10, 2024

Whoops thanks I had updated the path but didn't delete.

@vyasr vyasr requested a review from robertmaynard April 10, 2024 23:17
@vyasr
Copy link
Contributor Author

vyasr commented Apr 11, 2024 •
edited
Loading

This failure is odd. I see builds of other packages like cuml succeeding with the new patch from upstream rapids-cmake, so I wonder if there's something wrong with how this patch works with cudf's other patches. Since it's only happening with wheel builds I wonder if it's somehow caused by using static cudart, but I'll have to dig in further a bit later.

@vyasr
Copy link
Contributor Author

vyasr commented May 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 6d0f3d9 into rapidsai:branch-24.06 May 8, 2024
70 checks passed
@vyasr vyasr deleted the fix/cccl_kernel_pointer_hidden branch May 8, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@vyasr vyasr

Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @bdice @robertmaynard