Implement day_name and month_name to match pandas #15479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 8, 2024
mroeschke
reviewed
Apr 8, 2024
mroeschke
reviewed
Apr 8, 2024
mroeschke
reviewed
Apr 8, 2024
|
Thanks for the review @mroeschke ! Pushed a few changes to address your feedback. |
|
/okay to test |
|
/okay to test |
mroeschke
added
improvement
|
/okay to test |
|
/okay to test |
|
/okay to test |
vyasr
approved these changes
May 28, 2024
|
/merge |
|
Thanks for your initial work here @btepera |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
month_nameandday_namedatetime methods, matching the equivalent month_name and day_name methods from pandas.Currently this is implemented just for English locale, though it could be expanded to include additional languages in the future.
Closes #12407
Checklist