Ignore pandas tests for cudf.pandas that need motoserver #15468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
pandas
improvement
| @@ -193,9 +193,50 @@ and not test_numpy_ufuncs_basic[nullable_float-arctanh] \ | |||
| and not test_numpy_ufuncs_basic[nullable_float-deg2rad] \ | |||
| and not test_numpy_ufuncs_basic[nullable_float-rad2deg]" | |||
|
|
|||
|
|
|||
| # TODO: Needs motoserver/moto container running on http://localhost:5000 | |||
There was a problem hiding this comment.
Do you think this is hard to setup in our CI?
There was a problem hiding this comment.
It's not too hard to specify in terms of GHA https://github.com/pandas-dev/pandas/blob/main/.github/workflows/unit-tests.yml#L89-L124
But I'm unsure if there's any differences with our custom runners. I can check this out in a follow up
There was a problem hiding this comment.
We can do that as a follow-up.
galipremsagar
approved these changes
Apr 8, 2024
|
/merge |
jjacobelli
pushed a commit
to jjacobelli/cudf
that referenced
this pull request
Apr 9, 2024
) These test `ERROR` because they expect a connection to a mock S3 server. Ignoring these test for now until that is set up Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: rapidsai#15468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These test
ERRORbecause they expect a connection to a mock S3 server. Ignoring these test for now until that is set upChecklist