Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test_parsing in cudf.pandas tests #15460

Merged
merged 10 commits into from
Apr 20, 2024
Merged

Enable test_parsing in cudf.pandas tests #15460

merged 10 commits into from
Apr 20, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Apr 3, 2024 •
edited
Loading

Description

closes #15432

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 3, 2024
@mroeschke mroeschke requested a review from a team as a code owner April 3, 2024 21:29
@mroeschke mroeschke requested review from wence- and isVoid April 3, 2024 21:29
@mroeschke mroeschke changed the title Enable test_read_errors and test_parsing Enable test_read_errors and test_parsing in cudf.pandas tests Apr 3, 2024
@mroeschke mroeschke added pandas and removed Python Affects Python cuDF API. labels Apr 3, 2024
@vyasr
Copy link
Contributor

vyasr commented Apr 4, 2024

Looks like these tests fail.

@mroeschke mroeschke marked this pull request as draft April 8, 2024 21:16
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 15, 2024
@mroeschke mroeschke changed the title Enable test_read_errors and test_parsing in cudf.pandas tests Enable test_parsing in cudf.pandas tests Apr 16, 2024
@mroeschke mroeschke marked this pull request as ready for review April 16, 2024 20:19
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 14854b1 into rapidsai:branch-24.06 Apr 20, 2024
70 checks passed
@mroeschke mroeschke deleted the pandas/tests/enable2 branch April 20, 2024 00:33
@vyasr vyasr removed the pandas label May 16, 2024
@vyasr
Copy link
Contributor

vyasr commented May 17, 2024

This PR accidentally closed #15432. It should have closed #15431.

@vyasr vyasr mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Enable running tests/io/parser/common/test_read_errors.py in cudf.pandas tests
2 participants
@mroeschke @vyasr