-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle case of scan aggregation in groupby-transform #15450
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Copyright (c) 2024, NVIDIA CORPORATION. | ||
import itertools | ||
|
||
import pytest | ||
|
||
import cudf | ||
from cudf.testing._utils import assert_eq | ||
|
||
|
||
@pytest.fixture(params=[False, True], ids=["no-null-keys", "null-keys"]) | ||
def keys_null(request): | ||
return request.param | ||
|
||
|
||
@pytest.fixture(params=[False, True], ids=["no-null-values", "null-values"]) | ||
def values_null(request): | ||
return request.param | ||
|
||
|
||
@pytest.fixture | ||
def df(keys_null, values_null): | ||
keys = ["a", "b", "a", "c", "b", "b", "c", "a"] | ||
r = range(len(keys)) | ||
if keys_null: | ||
keys[::3] = itertools.repeat(None, len(r[::3])) | ||
values = list(range(len(keys))) | ||
if values_null: | ||
values[1::3] = itertools.repeat(None, len(r[1::3])) | ||
return cudf.DataFrame({"key": keys, "values": values}) | ||
|
||
|
||
@pytest.mark.parametrize("agg", ["cumsum", "cumprod", "max", "sum", "prod"]) | ||
def test_transform_broadcast(agg, df): | ||
pf = df.to_pandas() | ||
got = df.groupby("key").transform(agg) | ||
expect = pf.groupby("key").transform(agg) | ||
assert_eq(got, expect, check_dtype=False) | ||
|
||
|
||
def test_transform_invalid(): | ||
df = cudf.DataFrame({"key": [1, 1], "values": [4, 5]}) | ||
with pytest.raises(ValueError): | ||
df.groupby("key").transform({"values": "cumprod"}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care to raise the same error as pandas? This ends up hitting a
TypeError
in pandas for a few of the "bad" inputs that I tried like{"values": "cumprod"}
or the tuple("cumprod",)
or the integer3
. Only invalid function names (strings) raiseValueError
from what I can tell.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh probably, I didn't check exhaustively what pandas produces.