Re-enable all disabled/skipped pandas tests for cudf.pandas #15445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
| @@ -22,19 +22,6 @@ set -euo pipefail | |||
| # of Pandas installed. | |||
| PANDAS_VERSION=$(python -c "import pandas; print(pandas.__version__)") | |||
|
|
|||
| PYTEST_IGNORES="--ignore=tests/io/test_user_agent.py \ | |||
There was a problem hiding this comment.
Starting pandas-2, I for sure know we have hangs in this group of tests, we will need to investigate those hangs hence opened separate issues for each one so that it's easier to enable and check each file/directory separately
There was a problem hiding this comment.
Yeah although locally I am not seeing the hangs, I can see it in this PR now. I may have it narrowed it down to tests/tslibs/test_parsing.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Would supersede #15440, #15442, #15443, #15444
Now that we are cloning pandas 2.1.1 and testing with that version of the test suite, a lot of the prior skipping shouldn't be necessary due to the test suite using deterministic data and a few cleanups across the 2.x series.
Checklist