-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test static builds in CI and fix nanoarrow configure #15437
Merged
rapids-bot
merged 17 commits into
rapidsai:branch-24.06
from
vyasr:fix/nanoarrow_static_build
Apr 2, 2024
Merged
Test static builds in CI and fix nanoarrow configure #15437
rapids-bot
merged 17 commits into
rapidsai:branch-24.06
from
vyasr:fix/nanoarrow_static_build
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5009a99
to
a554f1f
Compare
AyodeAwe
approved these changes
Apr 2, 2024
bdice
reviewed
Apr 2, 2024
robertmaynard
requested changes
Apr 2, 2024
robertmaynard
approved these changes
Apr 2, 2024
bdice
approved these changes
Apr 2, 2024
/merge |
This fix allows our spark-rapids-jni builds to progress past the libcudf configure and successfully build and install libcudf. However once we try to use the installed libcudf, it fails with another nanoarrow issue. See #15453. |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
The new `configure_cpp_static.sh` script added in #15437 is calling `rapids-configure-conda-channels`. However, it is doing so on a `ci-wheel` image, which fails. This is causing CI issues and needs to be removed. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #15539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
CMake
CMake build issue
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #15275
Resolves #15434
Checklist