Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid importing dask-expr if "query-planning" config is False #15340

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

rjzamora
Copy link
Member

Description

During some offline debugging with @bdice and @divyegala, we discovered that some cuml tests are somehow failing after dask_expr is imported - Even if dask_expr is not actually being used. I'd like to figure out exactly what is causing that problem, but the first thing we can/should do is avoid the import altogether when the "query-planning" config is set to False.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added the bug Something isn't working label Mar 19, 2024
@rjzamora rjzamora self-assigned this Mar 19, 2024
@rjzamora rjzamora requested a review from a team as a code owner March 19, 2024 21:42
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 19, 2024
@rjzamora rjzamora added dask Dask issue non-breaking Non-breaking change labels Mar 19, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to fix the failing cuml test for me.

Ran with:

python -m pytest --cache-clear test_dask_nearest_neighbors.py::test_compare_skl[5-True-1-10-5-10-300] -s -v

I think this will resolve rapidsai/cuml#5803.

@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit f9ac427 into rapidsai:branch-24.04 Mar 19, 2024
75 checks passed
@rjzamora rjzamora deleted the avoid-dask-expr-import branch March 19, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants