-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable branch testing for cudf.pandas
#15316
Enable branch testing for cudf.pandas
#15316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. For a note on the second part (enabling comparisons), you'll need to be aware that these build jobs can be pre-empted and canceled if multiple merges happen in a short time frame. Your comparison scripts should compare to the most recent upload and not assume that the latest commit will have a result uploaded. You might need to look back several commits to find a job that completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we generally try to refrain from doing GPU tests on branch builds due to our limited GPU capacity.
is there any reason this can't be moved to the nightly test workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. I think you'll have to trigger this manually for now, which should be fine for testing.
Co-authored-by: Bradley Dice <[email protected]>
We do have the same job in |
/merge |
Description
This PR enables branch testing for
cudf.pandas
pandas pytest suite. This is 1st half of the actual changes I'd like to make. Once we merge this PR have a json file generated in s3 forbranch-24.04
, In a follow-up PR I will enable diff comparison and reporting.Checklist