Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable branch testing for cudf.pandas #15316

Merged
merged 12 commits into from
Mar 18, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 15, 2024

Description

This PR enables branch testing for cudf.pandas pandas pytest suite. This is 1st half of the actual changes I'd like to make. Once we merge this PR have a json file generated in s3 for branch-24.04, In a follow-up PR I will enable diff comparison and reporting.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 15, 2024
@galipremsagar galipremsagar self-assigned this Mar 15, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner March 15, 2024 02:49
@github-actions github-actions bot added the ci label Mar 15, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. For a note on the second part (enabling comparisons), you'll need to be aware that these build jobs can be pre-empted and canceled if multiple merges happen in a short time frame. Your comparison scripts should compare to the most recent upload and not assume that the latest commit will have a result uploaded. You might need to look back several commits to find a job that completed.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we generally try to refrain from doing GPU tests on branch builds due to our limited GPU capacity.

is there any reason this can't be moved to the nightly test workflow?

.github/workflows/build.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I think you'll have to trigger this manually for now, which should be fine for testing.

.github/workflows/pandas-tests.yaml Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

Seems fine to me. I think you'll have to trigger this manually for now, which should be fine for testing.

We do have the same job in test.yaml, so that will be run nightly and for on-demand runs I've created a new dedicated yaml.

.github/workflows/test.yaml Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2a85404 into rapidsai:branch-24.04 Mar 18, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants