This fixes an NPE when trying to read empty JSON data by adding a new API for missing information #15307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API for missing information Signed-off-by: Robert (Bobby) Evans <[email protected]>
revans2
added
3 - Ready for Review
ttnghia
reviewed
Mar 14, 2024
Comment on lines
335
to
336
| private static final byte[] EMPTY_JSON_DATA_BUFFER = ("{}\n").getBytes(StandardCharsets.UTF_8); | ||
| @Test |
There was a problem hiding this comment.
Nit:
Suggested change
| private static final byte[] EMPTY_JSON_DATA_BUFFER = ("{}\n").getBytes(StandardCharsets.UTF_8); | |
| @Test | |
| private static final byte[] EMPTY_JSON_DATA_BUFFER = ("{}\n").getBytes(StandardCharsets.UTF_8); | |
| @Test |
ttnghia
reviewed
Mar 14, 2024
Comment on lines
358
to
360
| private static final byte[] EMPTY_ARRAY_JSON_DATA_BUFFER = | ||
| ("{'a':[]}\n").getBytes(StandardCharsets.UTF_8); | ||
| @Test |
There was a problem hiding this comment.
Suggested change
| private static final byte[] EMPTY_ARRAY_JSON_DATA_BUFFER = | |
| ("{'a':[]}\n").getBytes(StandardCharsets.UTF_8); | |
| @Test | |
| private static final byte[] EMPTY_ARRAY_JSON_DATA_BUFFER = | |
| ("{'a':[]}\n").getBytes(StandardCharsets.UTF_8); | |
| @Test |
ttnghia
approved these changes
Mar 14, 2024
mythrocks
reviewed
Mar 14, 2024
| * @param buffer raw UTF8 formatted bytes. | ||
| * @param offset the starting offset into buffer. | ||
| * @param len the number of bytes to parse. | ||
| * @param emptyRowCount the number of rows to use if no columns were found. |
There was a problem hiding this comment.
I was wondering if there might be a better name for this. Under the circumstances, emptyRowCount is really the best name for this parameter.
mythrocks
approved these changes
Mar 14, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CUDF cannot create a table with rows and no columns, but that is exactly what we need to be able to read some JSON input. So this adds in a new API that lets us work around this problem if we know how many rows you expect to see. This is not an ideal solutions so it not a fix for #5712 generically. But is is a stop gap, especially for cases when we know how many rows to expect.
Checklist