Rework cudf::find_and_replace_all to use gather-based make_strings_column #15305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
davidwendt
added
3 - Ready for Review
mhaseeb123
reviewed
Mar 20, 2024
| rmm::cuda_stream_view stream, | ||
| rmm::mr::device_memory_resource* mr) | ||
| { | ||
| if (input.is_empty()) { return cudf::make_empty_column(type_id::STRING); } |
There was a problem hiding this comment.
should we check if (input.is_empty() or values_to_replace.empty() or replacement_values.empty()) instead?
There was a problem hiding this comment.
This is already handled by the caller:
https://github.com/rapidsai/cudf/pull/15305/files#diff-8c11e29e23c203bd58fd1ee8b6aca9d9b49e06edbaced8e68bbf4728f9a1ebc5R310-R312
So this check is probably not necessary. I can remove it.
mhaseeb123
approved these changes
Mar 20, 2024
pmattione-nvidia
approved these changes
Mar 20, 2024
KyleFromNVIDIA
approved these changes
Mar 22, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworks
cudf::find_and_replace_allfor strings to work with long strings and enable it to support large strings.The custom kernels were replaced with a gather-based
make_strings_columnalready optimized for long and short strings.Large strings will automatically be supported in
make_strings_columnin a future PR.Checklist