Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Doxygen upload directory #15291

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix Doxygen upload directory #15291

merged 1 commit into from
Mar 13, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

Prompted by #15101 (comment)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change labels Mar 13, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner March 13, 2024 18:50
@github-actions github-actions bot added the ci label Mar 13, 2024
@bdice bdice mentioned this pull request Mar 13, 2024
Closed
3 tasks
raydouglass
raydouglass approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@raydouglass raydouglass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth considering renaming the env-var used RAPIDS_VERSION_NUMBER https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-upload-docs#L17 to be RAPIDS_VERSION_MAJOR_MINOR which less ambiguous.

@ajschmidt8
Copy link
Member

It may be worth considering renaming the env-var used RAPIDS_VERSION_NUMBER https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-upload-docs#L17 to be RAPIDS_VERSION_MAJOR_MINOR which less ambiguous.

Yes, that would require changes across all the repos though. Alternatively we could just put a regex test in that script to ensure the string format matches the expected pattern.

@jakirkham jakirkham mentioned this pull request Mar 13, 2024
Merged
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 1ac1b2d into rapidsai:branch-24.04 Mar 13, 2024
75 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@raydouglass raydouglass mentioned this pull request Mar 25, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this pull request Mar 25, 2024
@raydouglass
Fix docs upload directory (#714)
3de344e 
Similar to rapidsai/cudf#15291, fixes the upload directory for docs (`24.04.00a30` => `24.04`).

Authors:
  - Ray Douglass (https://github.com/raydouglass)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleFromNVIDIA @ajschmidt8 @jakirkham @raydouglass