-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework cudf::replace_nulls to use strings::detail::copy_if_else #15286
Conversation
Can you post some benchmark number comparing before vs after this change please? |
Performance benchmark for this change.
This result is mainly from the gather logic now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. Very nice performance improvements, and the kernels are simpler.
/merge |
Description
Removes the specialized kernels for strings in
cudf::replace_nulls
and replaces them with a call tocudf::strings::detail::copy_if_else
which is already enabled with offsetalator support and optimized for long strings.This will also allow
cudf::replace_nulls
to use large strings with no further changes.Also includes a
replace_nulls
benchmark for strings.Checklist