-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up special casing in as_column
for non-typed input
#15276
Merged
rapids-bot
merged 21 commits into
rapidsai:branch-24.06
from
mroeschke:ref/as_columns/misc
Apr 17, 2024
Merged
Clean up special casing in as_column
for non-typed input
#15276
rapids-bot
merged 21 commits into
rapidsai:branch-24.06
from
mroeschke:ref/as_columns/misc
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
Affects Python cuDF API.
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Mar 12, 2024
3 tasks
… into ref/as_columns/misc
vyasr
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions to make sure that I followed everything. Thanks so much for this! Anything to simplify as_column
is amazing work.
vyasr
approved these changes
Apr 17, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redo at #14636
Clean up special casing for non-typed inputs to essentially do:
Additionally, this change matches a behavior with pandas that will parse string data with
dtype=datetime64
type similar to the 2.2 behavior (fail if the resolution of the type doesn't match the string data)Checklist