Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cudf::test::to_host return of host_vector #15263

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix cudf::test::to_host return of host_vector #15263

merged 3 commits into from
Mar 12, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Cleanup per comments in #15073:

Also removed some unneeded headers found in gather.cuh while working on this.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 8, 2024
@davidwendt davidwendt self-assigned this Mar 8, 2024
@davidwendt davidwendt marked this pull request as ready for review March 12, 2024 14:36
@davidwendt davidwendt requested a review from a team as a code owner March 12, 2024 14:36
bdice
bdice approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for following up on this.

@bdice bdice removed the 3 - Ready for Review Ready for review by team label Mar 12, 2024
@bdice
Copy link
Contributor

bdice commented Mar 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit a4e73a5 into rapidsai:branch-24.04 Mar 12, 2024
73 checks passed
@davidwendt davidwendt deleted the to-host-rtn-vector branch March 13, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @ttnghia