-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup hostdevice_vector
and add more APIs
#15252
Merged
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c3df9ad
Remove `current_size`
ttnghia 2a1e99a
Add `front()` and `back()`
ttnghia 4e3829d
Remove redundant headers
ttnghia eac0d51
Remove `push_back` API
ttnghia f931d43
Remove constructor using two size parameters
ttnghia 6ebc756
Fix callers
ttnghia f2ec56a
Remove `capacity`
ttnghia 17a596a
Merge branch 'branch-24.04' into bug_hd_vector
ttnghia 69f1d8d
Merge branch 'branch-24.04' into bug_hd_vector
ttnghia 0c149c3
Fix span test
ttnghia 4640d8c
Revert "Fix span test"
ttnghia 91e9338
Revert "Remove constructor using two size parameters"
ttnghia d7979d8
Revert "Remove `push_back` API"
ttnghia 2730507
Construct device vector in initializer list
ttnghia 4ed86b9
Revert changes in parquet code
ttnghia 259d082
Merge branch 'branch-24.04' into bug_hd_vector
ttnghia 034cdfe
Merge branch 'branch-24.04' into bug_hd_vector
ttnghia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you kidding me, this was it?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing, I just thought (feared) bigger changes were needed to remove push_back.